-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevObject types #21106
Merged
emilyrohrbough
merged 6 commits into
cypress-io:develop
from
atarek12:fix-prevSubject-types
Apr 21, 2022
Merged
fix: prevObject types #21106
emilyrohrbough
merged 6 commits into
cypress-io:develop
from
atarek12:fix-prevSubject-types
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
atarek12
force-pushed
the
fix-prevSubject-types
branch
from
April 15, 2022 22:47
d71d90b
to
5a99e37
Compare
5 tasks
flotwig
requested review from
flotwig,
sainthkh,
BlueWinds and
emilyrohrbough
and removed request for
jennifer-shehane and
flotwig
April 18, 2022 15:04
BlueWinds
approved these changes
Apr 19, 2022
emilyrohrbough
approved these changes
Apr 21, 2022
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fix
Cypress.Command.add()
TypeScript types. Fixes #20376element
while usingprevSubject: true
optionselector
to the subject while usingprevSubject: true | "element"
optionAdditional details
This change fixes typescript errors while using the
Cypress.Command.add()
with { prevSubject: true } or { prevSubject: "element" }How has the user experience changed?
No typescript error while trying to access the selector.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?